Question: are underscore-prefixed directories invalid?

[e2tha-e]

@bmuenzenmeyer @dmolsen

https://github.com/pattern-lab/patternlab-node/blob/master/core/lib/patternlab.js#L39
https://github.com/pattern-lab/patternlab-node/blob/master/core/lib/patternlab.js#L63

These two lines of code will cause Pattern Lab Node to not process files in underscore-prefixed directories. I've read through the official Pattern Lab docs and haven't found a mention of this. I've also had directories of this convention processed normally in Pattern Lab PHP, albeit in v1.x.x. Could you let me know if this condition is necessary? Because I'd like to be able work without this restriction.

[bmuenzenmeyer]

This code is in here because I thought it was on spec - but now I cannot find reference to it either.

@dmolsen am I mistaken?

[dmolsen]

@bmuenzenmeyer -

I would have said it was on spec but I can't find it in my code. Adding an _ to a type or subtype doesn't clean it properly either. Sorry, without checking I would have agreed with you. Happy to go in the direction you want.

[e2tha-e]

I feel it would be appropriate to hide underscore-prefixed directories in the UI, but the code as it is completely ignores them. I would like to be able to continue processing them whether in PHP or in Node.

[dmolsen]

That would be similar to how underscores work now for individual patterns. Marked hidden for nav purposes but still available to include elsewhere.

On Jul 27, 2016, at 8:40 AM, e2tha-e [email protected] wrote:

I feel it would be appropriate to hide underscore-prefixed directories in the UI, but the code as it is completely ignores them. I would like to be able to continue processing them whether in PHP or in Node.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[bmuenzenmeyer]

Implemented in 2.4.0