Addresses #375 allow foo.json #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code looks good to me! |
|
I am crazy excited to see another thorough, well-thought out PR @stevemartin - you don't know how much it means to me and @geoffp to receive contributions! 😊 My only comment would again be dependencies. We have lodash and a custom merge function which I think should do the same thing as the merge library you included. Can you try either of those? Again, this isn't meant to in any way degrade what you've done here. Merely trying to be mindful of dependencies/code bloat/redundancy as the project grows. THANK YOU! |
* glob data files in data folder, excluding listitems * merge data as global data * tests inform code * use lodash for merge
|
@bmuenzenmeyer no problem, all good learnings! :) |
|
will try to review this tomorrow! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #375
Summary of changes: