Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support foo.json files inside _data/ that are not listitems.json to be added to the global data object #375

Closed
bmuenzenmeyer opened this issue Jun 30, 2016 · 2 comments
Closed

Support foo.json files inside _data/ that are not listitems.json to be added to the global data object #375

bmuenzenmeyer opened this issue Jun 30, 2016 · 2 comments
Labels
enhancement ✨ gap from php 🙈 staged for next release 🏁
Milestone
3.X.X

Comments

@bmuenzenmeyer
Copy link
Member

Dave informed me during WebDesignDay that a user should be able to structure files inside _data/ as follows:

_data/
 - data.json
 - foo.json
 - listitems.json
 - zed.json

And expect data.json, foo.json, and zed.json to be merged together as global data.
@bmuenzenmeyer bmuenzenmeyer added this to the 2.X milestone Jun 30, 2016
@bramsmulders
Copy link
Contributor

This is totally what i want, currently i'm fixing this issue by merging seperate data files into data.json before patternlab runs. But it would be awesome to have this included. :)

@bramsmulders bramsmulders mentioned this issue Jul 6, 2016
Closed
@bmuenzenmeyer
Copy link
Member Author

Good to hear there is interest, I didn't even know the feature in PL/PHP existed until Dave Brad and I got together a couple weeks ago. I will try to prioritize this, but cannot promise anything concrete yet besides "soon"

stevemartin pushed a commit to stevemartin/patternlab-node that referenced this issue Jul 21, 2016
@tevio
Addresses pattern-lab#375
9c3b1bb 
* glob data files in data folder, excluding listitems
* merge data as global data
@stevemartin stevemartin mentioned this issue Jul 21, 2016
Closed
stevemartin pushed a commit to stevemartin/patternlab-node that referenced this issue Jul 21, 2016
@tevio
Addresses pattern-lab#375
45aecc9 
* glob data files in data folder, excluding listitems
* merge data as global data
@stevemartin stevemartin mentioned this issue Jul 21, 2016
Merged
stevemartin pushed a commit to stevemartin/patternlab-node that referenced this issue Jul 21, 2016
@tevio
Addresses pattern-lab#375
e712694 
* glob data files in data folder, excluding listitems
* merge data as global data
stevemartin pushed a commit to stevemartin/patternlab-node that referenced this issue Jul 22, 2016
@tevio
Addresses pattern-lab#375
a88e73d 
* glob data files in data folder, excluding listitems
* merge data as global data
* tests inform code
* use lodash for merge
bmuenzenmeyer pushed a commit that referenced this issue Jul 24, 2016
Merge pull request #400 from stevemartin/dev
e76bc53 
Addresses #375 allow foo.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ✨ gap from php 🙈 staged for next release 🏁
Projects
None yet
Milestone
3.X.X
Development

No branches or pull requests
2 participants
@bmuenzenmeyer @bramsmulders