Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing demo project makeAssertionOptions.status processing #551

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

Fasjeit
Copy link
Contributor

@Fasjeit Fasjeit commented Oct 8, 2024

As it looks like #535 is tacking too long to make requested changes, here is another PR with (hopefully) fully functional demo site.

Fixes #534

@Fasjeit
Copy link
Contributor Author

Fasjeit commented Oct 8, 2024

@Fasjeit please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.99%. Comparing base (26e5f75) to head (ec18b58).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #551   +/-   ##
=======================================
  Coverage   73.99%   73.99%           
=======================================
  Files          97       97           
  Lines        2638     2638           
  Branches      446      446           
=======================================
  Hits         1952     1952           
  Misses        585      585           
  Partials      101      101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abergs abergs merged commit 0ea57fd into passwordless-lib:master Oct 18, 2024
11 checks passed
@abergs
Copy link
Collaborator

abergs commented Oct 18, 2024

Thank you @Fasjeit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seems like the latest change has broken the demo project.
3 participants