Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seems like the latest change has broken the demo project. #534

Closed
bgirts opened this issue Jul 29, 2024 · 4 comments · Fixed by #551
Closed

Seems like the latest change has broken the demo project. #534

bgirts opened this issue Jul 29, 2024 · 4 comments · Fixed by #551

Comments

@bgirts
Copy link

bgirts commented Jul 29, 2024

Hi!

image

The registration js file still relies on "ok" status, thus demo project is broken.

image

Probably changing to this should fix the issue, at least quick local change seems to work for me.

image

Error details

image
image
image

@abergs
Copy link
Collaborator

abergs commented Jul 30, 2024

Agreed, demo is currently a bit out of sync with the API.

@yagiz-aydin
Copy link

yagiz-aydin commented Jul 31, 2024

Agreed, fix on this PR
@abergs @bgirts
#535

@andrew-armitage
Copy link

I just tried to run this and found that there is no 'Status' field in the data. Looking at the js, status refers to the status code from the API and only the data is taken from the response.

@abergs
Copy link
Collaborator

abergs commented Aug 3, 2024

@andrew-armitage Yes, a fix is incoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants