Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename extensions to clientExtensionResults #485

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Rename extensions to clientExtensionResults #485

merged 2 commits into from
Jan 5, 2024

Conversation

joegoldman2
Copy link
Contributor

@joegoldman2 joegoldman2 commented Jan 4, 2024

Following #474, same change has been done on AuthenticatorAttestationRawResponse. Additionally, the new clientExtensionResults is now used in Fido2.BlazorWebAssembly project.

@abergs, do you want me to update the demo project as well to use the new ClientExtensionResults prop?

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (31a4f94) 74.25% compared to head (e7116e0) 74.19%.

Files Patch % Lines
...ido2.Models/AuthenticatorAttestationRawResponse.cs 33.33% 2 Missing ⚠️
Src/Fido2/AuthenticatorAttestationResponse.cs 0.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
- Coverage   74.25%   74.19%   -0.06%     
==========================================
  Files         100      100              
  Lines        2707     2709       +2     
  Branches      444      444              
==========================================
  Hits         2010     2010              
- Misses        593      595       +2     
  Partials      104      104              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonashendrickx
Copy link
Contributor

Thank you @joegoldman2!

Copy link
Collaborator

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abergs
Copy link
Collaborator

abergs commented Jan 5, 2024

@abergs, do you want me to update the demo project as well to use the new ClientExtensionResults prop?

Sure, it was intentionally left to prove backwards compatability in testing but could be cleaned up now

@abergs abergs merged commit c2f384d into passwordless-lib:master Jan 5, 2024
11 checks passed
@joegoldman2 joegoldman2 deleted the rename-extensions branch January 5, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants