Rename 'extensions' to 'clientExtensionResults' for deserialization #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uring registration.
|
We found this issue while using the Google android FIDO2 API. Currently, we have fixed this issue here by just renaming the "clientExtensionResults" to "extensions" and then sending to backend. |
|
@jonashendrickx This PR contains conflicts that stops it from being merged |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #474 +/- ##
==========================================
- Coverage 74.30% 74.25% -0.06%
==========================================
Files 100 100
Lines 2705 2707 +2
Branches 444 444
==========================================
Hits 2010 2010
- Misses 591 593 +2
Partials 104 104 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently using 'extensions' instead of 'clientExtensionResults', this requires us to map the property from the PublicKeyCredential object in the browser, or Google FIDO2 API.
The demo applications have been left to use the original 'extensions' property for the registration, to demonstrate the change is backwards compatible.
I first renamed the property, and ensured the project was building and all references were correctly pointing to the new property. Then added the obsolete property back. There shouldn't be any leaks.