Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CredentialMakeResult to MakeNewCredentialResult and adjust its namespace #433

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Rename CredentialMakeResult to MakeNewCredentialResult and adjust its namespace #433

merged 3 commits into from
Nov 3, 2023

Conversation

joegoldman2
Copy link
Contributor

Fixes #432

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@9bbbfc2). Learn more about missing BASE report.
Report is 50 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #433   +/-   ##
=========================================
  Coverage          ?   77.52%           
=========================================
  Files             ?       99           
  Lines             ?     2714           
  Branches          ?      445           
=========================================
  Hits              ?     2104           
  Misses            ?      491           
  Partials          ?      119

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iamcarbon
Copy link
Contributor

@joegoldman2 Let's rename this type to MakeNewCredentialResult while we are here.

@joegoldman2 joegoldman2 changed the title Move CredentialMakeResult to Fido2NetLib.Objects namespace Rename CredentialMakeResult to MakeNewCredentialResult and adjust its namespace Oct 9, 2023
@iamcarbon
Copy link
Contributor

👍

@aseigler aseigler self-requested a review October 23, 2023 14:11
@joegoldman2 joegoldman2 requested a review from aseigler October 25, 2023 06:14
abergs
abergs approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @aseigler anything or are we good to merge?

@aseigler
Copy link
Collaborator

aseigler commented Nov 2, 2023

LGTM. @aseigler anything or are we good to merge?

I'm happy if you're happy!

@aseigler aseigler merged commit 1e32b9b into passwordless-lib:master Nov 3, 2023
7 checks passed
@joegoldman2 joegoldman2 deleted the fix/432 branch November 3, 2023 18:16
@abergs abergs added this to the Version 4 milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abergs abergs abergs approved these changes

@aseigler aseigler Awaiting requested review from aseigler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 4
Development

Successfully merging this pull request may close these issues.

Namespace inconsistency between CredentialMakeResult and AssertionVerificationResult
5 participants
@joegoldman2 @codecov-commenter @iamcarbon @aseigler @abergs