Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespace inconsistency between CredentialMakeResult and AssertionVerificationResult #432

Closed
ghost opened this issue Oct 7, 2023 · 0 comments · Fixed by #433
Closed

Namespace inconsistency between CredentialMakeResult and AssertionVerificationResult #432

ghost opened this issue Oct 7, 2023 · 0 comments · Fixed by #433

Comments

@ghost
Copy link

ghost commented Oct 7, 2023 •
edited by ghost
Loading

CredentialMakeResult should not be a class child of Fido2NetLib.Fido2. AssertionVerificationResult is at the root of the namespace Fido2NetLib.Objects. We should probably move CredentialMakeResult under the namespace Fido2NetLib.Objects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename CredentialMakeResult to MakeNewCredentialResult and adjust its namespace
0 participants