Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed name change of bolts dependency #111

Merged

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Jun 18, 2020

The name of the internalized bolts dependency has been changed from bolts to boltsinternal with parse-community/Parse-SDK-Android#1033.

This PR reflects these changes in the LiveQuery SDK.

closes parse-community/Parse-SDK-Android#1036

This can be avoided in the future if we add the LiveQuery SDK as a module to the Parse Android SDK.

@Jawnnypoo
Copy link
Member

I think it makes sense to add it as a module, feel free to make a PR doing so if you'd like.

@mtrezza
Copy link
Member Author

mtrezza commented Jun 18, 2020

@Jawnnypoo I think travis is stuck, the status is not changing for hours.

@Jawnnypoo
Copy link
Member

Looks like it succeeded but didn't notify. https://travis-ci.org/github/parse-community/ParseLiveQuery-Android
You can just make a dummy commit to this PR to re-trigger it.

@mtrezza
Copy link
Member Author

mtrezza commented Jun 18, 2020

Can you add me as collab to this repo as well?

@Jawnnypoo
Copy link
Member

I cannot, I don't have the rights for this repo.

@Jawnnypoo Jawnnypoo merged commit 095dae0 into parse-community:master Jun 18, 2020
@Jawnnypoo
Copy link
Member

Maybe @TomWFox can?

@TomWFox
Copy link
Contributor

TomWFox commented Jun 18, 2020

Trying to avoid collaborators as it makes it harder to track perms across the whole org. @mtrezza I've been thinking we should invite you to join the team for a while, is this something you would be interested in? - then I could add you to the Parse Server and Android teams.

@mtrezza
Copy link
Member Author

mtrezza commented Jun 18, 2020

@TomWFox sure, please go ahead

@TomWFox
Copy link
Contributor

TomWFox commented Jun 18, 2020

Great, the procedure involves a vote on the forum, unfortunately I lost a nice template I'd made for those so you'll have to give me a bit of time to get it all sorted.

@mtrezza
Copy link
Member Author

mtrezza commented Jun 18, 2020

Sure, no rush

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bolts conflicts
3 participants