Fix bolts duplicate classes #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaming bolts-tasks module to fix naming conflict with legacy bolts library
Jawnnypoo
approved these changes
Jun 17, 2020
|
Thanks for the fast release 👍 |
This was referenced Jun 18, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The bolts-tasks module has been added natively to this library in #1018 without changing its name. This creates a naming conflict with transitively added legacy-bolts module.
Solution
Renamed internalized package to
com.parse.boltsinternal. This allows to keep the original module namebolts-tasksand if necessary other modules of the Bolts framework be internalized in the future without changing their names.closes #1028