Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: query constraint == #49

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Bug fix: query constraint == #49

merged 1 commit into from
Jan 11, 2021

Conversation

cbaker6
Copy link
Contributor

@cbaker6 cbaker6 commented Jan 11, 2021

== was originally using $eq which works with Parse-Server, but isn't listed in the REST documentation. The problem is that the LiveQuery server doesn't use $eq, so this fix makes the SDK encode == in a way that's compatible with both the Parse Server and LiveQuery server.

  • Fix related test cases.

@codecov
Copy link

codecov bot commented Jan 11, 2021

Codecov Report

Merging #49 (a0d8a07) into main (ca096b5) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   76.63%   76.65%   +0.02%     
==========================================
  Files          42       42              
  Lines        3757     3757              
==========================================
+ Hits         2879     2880       +1     
+ Misses        878      877       -1     
Impacted Files Coverage Δ
Sources/ParseSwift/Types/Query.swift 91.54% <100.00%> (ø)
Sources/ParseSwift/Objects/ParseObject.swift 76.84% <0.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca096b5...a0d8a07. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant