-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds equalTo QueryConstraint along which uses $eq #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
Codecov Report
@@ Coverage Diff @@
## main #310 +/- ##
==========================================
- Coverage 84.63% 84.57% -0.07%
==========================================
Files 114 114
Lines 11701 11718 +17
==========================================
+ Hits 9903 9910 +7
- Misses 1798 1808 +10
Continue to review full report at Codecov.
|
Conflicts: Sources/ParseSwift/Parse.swift Tests/ParseSwiftTests/ParseQueryTests.swift
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
$eq
was removed in a #49 which allowed for multipleQueryConstraint
's to be used on a singlekey
, though it's currently not supported by the LiveQuery server.Related issue: #n/a
Approach
Adds equalTo QueryConstraint along with ability to change the SDK default behavior of using
$eq
QueryConstraint parameter or not.TODOs before merging
notNull()
toisNotNull()
from feat: Add isNull QueryConstraint and set/foreset null operations #308