Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for AnonymousUtils #860

Merged
merged 2 commits into from
Jul 11, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion integration/test/ParseUserTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,6 @@ describe('Parse User', () => {
Parse.User.enableUnsafeCurrentUser();

await Parse.User.signUp('foobaz', '1234');
await Parse.User.logOut();

const user = await Parse.AnonymousUtils.logIn();
user.set('field', 'hello world');
Expand All @@ -552,6 +551,27 @@ describe('Parse User', () => {
}
});

it('anonymous user logIn does not use currentUser sessionToken', async () => {
Parse.User.enableUnsafeCurrentUser();

const user1 = await Parse.User.signUp('anon-not', '1234');
const user2 = await Parse.AnonymousUtils.logIn();
expect(user1.getSessionToken()).toBeDefined();
expect(user2.getSessionToken()).toBeDefined();
expect(user1.getSessionToken()).not.toBe(user2.getSessionToken());
});

it('facebook logIn does not use currentUser sessionToken', async () => {
Parse.User.enableUnsafeCurrentUser();
Parse.FacebookUtils.init();

const user1 = await Parse.User.signUp('facebook-not', '1234');
const user2 = await Parse.FacebookUtils.logIn();
expect(user1.getSessionToken()).toBeDefined();
expect(user2.getSessionToken()).toBeDefined();
expect(user1.getSessionToken()).not.toBe(user2.getSessionToken());
});

it('can signUp user with subclass', async () => {
Parse.User.enableUnsafeCurrentUser();

Expand Down
11 changes: 7 additions & 4 deletions src/AnonymousUtils.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
*/
import ParseUser from './ParseUser';
const uuidv4 = require('uuid/v4');
import type { RequestOptions } from './RESTController';

let registered = false;

Expand Down Expand Up @@ -62,12 +63,13 @@ const AnonymousUtils = {
*
* @method logIn
* @name Parse.AnonymousUtils.logIn
* @param {Object} options MasterKey / SessionToken.
* @returns {Promise}
* @static
*/
logIn() {
logIn(options?: RequestOptions) {
const provider = this._getAuthProvider();
return ParseUser._logInWith(provider.getAuthType(), provider.getAuthData());
return ParseUser._logInWith(provider.getAuthType(), provider.getAuthData(), options);
},

/**
Expand All @@ -76,12 +78,13 @@ const AnonymousUtils = {
* @method link
* @name Parse.AnonymousUtils.link
* @param {Parse.User} user User to link. This must be the current user.
* @param {Object} options MasterKey / SessionToken.
* @returns {Promise}
* @static
*/
link(user: ParseUser) {
link(user: ParseUser, options?: RequestOptions) {
const provider = this._getAuthProvider();
return user._linkWith(provider.getAuthType(), provider.getAuthData());
return user._linkWith(provider.getAuthType(), provider.getAuthData(), options);
},

_getAuthProvider() {
Expand Down
10 changes: 6 additions & 4 deletions src/ParseUser.js
Original file line number Diff line number Diff line change
Expand Up @@ -685,8 +685,8 @@ class ParseUser extends ParseObject {
return controller.hydrate(userJSON);
}

static logInWith(provider: any, options?: RequestOptions) {
return ParseUser._logInWith(provider, options);
static logInWith(provider: any, options: { authData?: AuthData }, saveOpts?: FullOptions) {
return ParseUser._logInWith(provider, options, saveOpts);
}

/**
Expand Down Expand Up @@ -804,9 +804,11 @@ class ParseUser extends ParseObject {
});
}

static _logInWith(provider: any, options?: RequestOptions) {
static _logInWith(provider: any, options: { authData?: AuthData }, saveOpts?: FullOptions = {}) {
saveOpts.sessionToken = saveOpts.sessionToken || '';

const user = new ParseUser();
return user._linkWith(provider, options);
return user._linkWith(provider, options, saveOpts);
}

static _clearCache() {
Expand Down
4 changes: 2 additions & 2 deletions src/__tests__/AnonymousUtils-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,15 +74,15 @@ describe('AnonymousUtils', () => {
jest.spyOn(user, '_linkWith');
AnonymousUtils.link(user);
expect(user._linkWith).toHaveBeenCalledTimes(1);
expect(user._linkWith).toHaveBeenCalledWith('anonymous', mockProvider.getAuthData());
expect(user._linkWith).toHaveBeenCalledWith('anonymous', mockProvider.getAuthData(), undefined);
expect(AnonymousUtils._getAuthProvider).toHaveBeenCalledTimes(1);
});

it('can login user', () => {
jest.spyOn(MockUser, '_logInWith');
AnonymousUtils.logIn();
expect(MockUser._logInWith).toHaveBeenCalledTimes(1);
expect(MockUser._logInWith).toHaveBeenCalledWith('anonymous', mockProvider.getAuthData());
expect(MockUser._logInWith).toHaveBeenCalledWith('anonymous', mockProvider.getAuthData(), undefined);
expect(AnonymousUtils._getAuthProvider).toHaveBeenCalledTimes(1);
});
});