Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for AnonymousUtils #860

Merged
merged 2 commits into from
Jul 11, 2019
Merged

Add options for AnonymousUtils #860

merged 2 commits into from
Jul 11, 2019

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jul 11, 2019

This PR also addresses an issue.

const user1 = await Parse.User.signUp('anon-not', '1234'); // is current user
const user2 = await Parse.AnonymousUtils.logIn(); // request are made with user1 sessionToken
user2.set('foo', 'bar');
// user2 doesn't have a sessionToken because of https://github.com/parse-community/parse-server/pull/5801
// LinkWith sessionToken won't generate new session token
user2.save();

@dplewis dplewis requested a review from acinader July 11, 2019 20:04
@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

Merging #860 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #860      +/-   ##
==========================================
+ Coverage   92.09%   92.12%   +0.02%     
==========================================
  Files          54       54              
  Lines        4987     4988       +1     
  Branches     1112     1114       +2     
==========================================
+ Hits         4593     4595       +2     
+ Misses        394      393       -1
Impacted Files Coverage Δ
src/AnonymousUtils.js 100% <100%> (ø) ⬆️
src/ParseUser.js 83.18% <100%> (+0.03%) ⬆️
src/ParseObject.js 90.21% <0%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93c0538...2e6bffc. Read the comment docs.

Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dplewis
Copy link
Member Author

dplewis commented Jul 11, 2019

I’m going to write a few test them draft a release

@dplewis dplewis requested review from acinader and davimacedo July 11, 2019 20:45
Copy link
Contributor

@acinader acinader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dplewis dplewis merged commit b3f867f into master Jul 11, 2019
@dplewis dplewis deleted the anon-options branch July 11, 2019 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants