Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ParseXFile for cross-platform XFile support #990

Merged
merged 10 commits into from
Mar 30, 2024

Conversation

mbfakourii
Copy link
Member

@mbfakourii mbfakourii commented Mar 9, 2024

Pull Request

Issue

Add ParseXFile for support XFile.

Closes: #989

Approach

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

Copy link

Thanks for opening this pull request!

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 64 lines in your changes are missing coverage. Please review.

Project coverage is 43.37%. Comparing base (540b127) to head (09289a6).

Files Patch % Lines
packages/dart/lib/src/objects/parse_x_file.dart 0.00% 62 Missing ⚠️
packages/dart/lib/src/objects/parse_file.dart 0.00% 1 Missing ⚠️
packages/dart/lib/src/objects/parse_file_web.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #990      +/-   ##
==========================================
- Coverage   44.16%   43.37%   -0.80%     
==========================================
  Files          60       61       +1     
  Lines        3401     3463      +62     
==========================================
  Hits         1502     1502              
- Misses       1899     1961      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza
Copy link
Member

mtrezza commented Mar 19, 2024

Is this ready for merge?

@mbfakourii mbfakourii requested a review from a team March 20, 2024 14:12
@mbfakourii
Copy link
Member Author

Is this ready for merge?

Yes, I think it is ready to merge.

packages/dart/CHANGELOG.md Outdated Show resolved Hide resolved
mtrezza
mtrezza previously approved these changes Mar 30, 2024
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza changed the title feat: Add ParseXFile feat: Add ParseXFile for XFile support Mar 30, 2024
@mtrezza mtrezza changed the title feat: Add ParseXFile for XFile support feat: Add ParseXFile for cross-platform XFile support Mar 30, 2024
packages/dart/CHANGELOG.md Outdated Show resolved Hide resolved
@mtrezza mtrezza merged commit c388545 into parse-community:master Mar 30, 2024
13 of 15 checks passed
@mtrezza
Copy link
Member

mtrezza commented Mar 30, 2024

I just noticed that the docs workflow was skipped; shouldn't docs be published?

https://github.com/parse-community/Parse-SDK-Flutter/actions/runs/8493279325/job/23267194136

@mbfakourii
Copy link
Member Author

I just noticed that the docs workflow was skipped; shouldn't docs be published?

https://github.com/parse-community/Parse-SDK-Flutter/actions/runs/8493279325/job/23267194136

I think this section had a problem in ci.

@mtrezza
Copy link
Member

mtrezza commented Mar 31, 2024

I tried to run it manually but it also wouldn't run. I'll look into it. #991

@mbfakourii mbfakourii deleted the add-parse-x-file branch October 17, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support XFile
2 participants