Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support XFile #989

Closed
3 tasks done
mbfakourii opened this issue Mar 9, 2024 · 5 comments · Fixed by #990
Closed
3 tasks done

Support XFile #989

mbfakourii opened this issue Mar 9, 2024 · 5 comments · Fixed by #990
Labels
type:feature New feature or improvement of existing feature

Comments

@mbfakourii
Copy link
Member

mbfakourii commented Mar 9, 2024

New Feature / Enhancement Checklist

Current Limitation

When we want to use the file both on the web and the normal file in the project, we face problems in Parse projects.
For this reason, I suggest to merge ParseWebFile and ParseFile together.

Feature / Enhancement Description

I suggest using XFile to solve this problem. With this function, we support both normal File and Uint8List.

Example Use Case

n/a

Alternatives / Workarounds

There is no use of both types of files in Parse when we register the file.

Copy link

parse-github-assistant bot commented Mar 9, 2024

Thanks for opening this issue!

  • 🎉 We are excited about your ideas for improvement!

@mbfakourii mbfakourii added the type:feature New feature or improvement of existing feature label Mar 9, 2024
@mtrezza
Copy link
Member

mtrezza commented Mar 9, 2024

Does this SDK already have a ParseFile class like other Parse SDKs, and if yes, will it be replaced by ParseXFile?

@mbfakourii
Copy link
Member Author

mbfakourii commented Mar 9, 2024

Does this SDK already have a ParseFile class like other Parse SDKs, and if yes, will it be replaced by ParseXFile?

In Parse SDK Flutter, we use two types of ParseWebFile to support Flutter Web and ParseFile for other platforms.

In large projects that require the output of all platforms from Flutter, including the web, it is necessary to use both ParseWebFile and ParseFile. This is where we run into conflict problems. XFile is a type of file created by the Flutter team and tries to Solve the file problem in platforms and web. Therefore, I suggest that this item be added to Parse SDK Flutter.

Your suggestion for replaced with ParseFile is also very good, but it is better for ParseXFile to be tested and evaluated more and in the future to be merged with ParseFile with a breaking change.

@mtrezza
Copy link
Member

mtrezza commented Mar 9, 2024

So there will be a ParseFile, ParseWebFile, ParseXFile for now, and in the future ParseWebFile and ParseXFile will be merged into ParseFile? Sounds like a good plan.

@mbfakourii
Copy link
Member Author

mbfakourii commented Mar 10, 2024

So there will be a ParseFile, ParseWebFile, ParseXFile for now, and in the future ParseWebFile and ParseXFile will be merged into ParseFile? Sounds like a good plan.

Yes, this is the best plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or improvement of existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants