This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Check if BEEFY authority is in current set #10281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seunlanlege
changed the title
bkchr
reviewed
Nov 16, 2021
Co-authored-by: Bastian Köcher <[email protected]>
bkchr
reviewed
Nov 16, 2021
adoerr
added
A2-insubstantial
adoerr
reviewed
Nov 16, 2021
Co-authored-by: Andreas Doerr <[email protected]>
|
@adoerr looks good? |
adoerr
approved these changes
Nov 17, 2021
client/beefy/src/round.rs
Outdated
| @@ -36,7 +36,7 @@ impl RoundTracker { | |||
| fn add_vote(&mut self, vote: (Public, Signature)) -> bool { | |||
| // this needs to handle equivocations in the future | |||
| if self.votes.contains(&vote) { | |||
| return false; | |||
| false | |||
There was a problem hiding this comment.
Apparently I'm just stupid 🙈 . My change is BS of course. Please just revert the last commit.
There was a problem hiding this comment.
Lmao, if it makes you feel better, i would've made the same mistake too 🤣
bkchr
approved these changes
Nov 17, 2021
|
A bit shame that such an important piece of code was accepted without a single test case. |
|
🥲 |
|
I'll add some |
aurexav
pushed a commit
to darwinia-network/substrate
that referenced
this pull request
Jan 27, 2022
* check if BEEFY authority is in current set * Update client/beefy/src/round.rs Co-authored-by: Bastian Köcher <[email protected]> * Update client/beefy/src/round.rs * Update client/beefy/src/round.rs Co-authored-by: Andreas Doerr <[email protected]> * remove stray semi Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Andreas Doerr <[email protected]>
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* check if BEEFY authority is in current set * Update client/beefy/src/round.rs Co-authored-by: Bastian Köcher <[email protected]> * Update client/beefy/src/round.rs * Update client/beefy/src/round.rs Co-authored-by: Andreas Doerr <[email protected]> * remove stray semi Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Andreas Doerr <[email protected]>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* check if BEEFY authority is in current set * Update client/beefy/src/round.rs Co-authored-by: Bastian Köcher <[email protected]> * Update client/beefy/src/round.rs * Update client/beefy/src/round.rs Co-authored-by: Andreas Doerr <[email protected]> * remove stray semi Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Andreas Doerr <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes paritytech/grandpa-bridge-gadget#100