Skip to content
This repository has been archived by the owner on Nov 11, 2022. It is now read-only.

Validate signatures for votes received from peers #100

Closed
adoerr opened this issue Mar 5, 2021 · 3 comments · Fixed by paritytech/substrate#10281
Closed

Validate signatures for votes received from peers #100

adoerr opened this issue Mar 5, 2021 · 3 comments · Fixed by paritytech/substrate#10281
Labels
enhancement New feature or request good first issue Good for newcomers M-gadget The client code of the gadget.

Comments

@adoerr
Copy link
Contributor

adoerr commented Mar 5, 2021

BeefyWorker::handle_vote() should validate vote signatures before processing them.
@adoerr adoerr added enhancement New feature or request M-gadget The client code of the gadget. labels Mar 5, 2021
@andresilva andresilva mentioned this issue Apr 8, 2021
Merged
@andresilva
Copy link
Contributor

#142 implemented verification of the signatures but we still need to make sure the given signer is part of the validator set.

@adoerr
Copy link
Contributor Author

adoerr commented Apr 8, 2021

Verify , that the msg.id in this line is a member of the validator set.

@tomusdrw
Copy link
Contributor

This could also be done in Round structure (add_vote) or earlier.

@tomusdrw tomusdrw added the good first issue Good for newcomers label Nov 15, 2021
@seunlanlege seunlanlege mentioned this issue Nov 16, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers M-gadget The client code of the gadget.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check if BEEFY authority is in current set seunlanlege/substrate
3 participants
@andresilva @tomusdrw @adoerr