Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove Duplicate Traits #5536

Merged
merged 2 commits into from
May 17, 2022
Merged

Remove Duplicate Traits #5536

merged 2 commits into from
May 17, 2022

Conversation

shawntabrizi
Copy link
Member

@shawntabrizi shawntabrizi commented May 16, 2022 •
edited
Loading

Found these traits laying around the Parachain Primitives, all of which exist in sp-runtime already.

#360 was supposed to track this but was prematurely closed.

I see no reason why these traits need to be duplicated at this point.

Cumulus Companion: paritytech/cumulus#1264

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label May 16, 2022
@shawntabrizi shawntabrizi added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 16, 2022
@shawntabrizi shawntabrizi added B7-runtimenoteworthy and removed B0-silent Changes should not be mentioned in any release notes labels May 16, 2022
@shawntabrizi shawntabrizi mentioned this pull request May 17, 2022
Merged
KiChjang
KiChjang approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@KiChjang KiChjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me that we pulled in sp_runtime anyway, so the issue raised in #360 doesn't apply anymore.

@shawntabrizi
Copy link
Member Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 21323b7 into master May 17, 2022
@paritytech-processbot paritytech-processbot bot deleted the shawntabrizi-eliminate-duplicate-traits branch May 17, 2022 06:37
@shawntabrizi
Copy link
Member Author

It looks to me that we pulled in sp_runtime anyway, so the issue raised in #360 doesn't apply anymore.

I believe this was an issue back in the day, before a large refactor of the crates. Note the crate name is sr rather than sp. I believe the refactor happened here.

ordian added a commit that referenced this pull request May 17, 2022
@ordian
Merge branch 'master' into ao-disputes-offences-runtime
23494c6 
* master:
  Bump femme from 2.2.0 to 2.2.1 (#5534)
  Add counter for bounded channel sends that block. (#5490)
  Remove Duplicate Traits (#5536)
@github-actions github-actions bot mentioned this pull request Jun 22, 2022
Closed
This was referenced Jul 18, 2022
Closed
Open
@ghbot-test ghbot-test bot mentioned this pull request Jul 28, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@KiChjang KiChjang KiChjang approved these changes

@athei athei athei approved these changes

@tomusdrw tomusdrw Awaiting requested review from tomusdrw

@svyatonik svyatonik Awaiting requested review from svyatonik

@acatangiu acatangiu Awaiting requested review from acatangiu

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shawntabrizi @athei @KiChjang