Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add counter for bounded channel sends that block. #5490

Merged
merged 7 commits into from
May 17, 2022
Merged

Add counter for bounded channel sends that block. #5490

merged 7 commits into from
May 17, 2022

Conversation

sandreim
Copy link
Contributor

@sandreim sandreim commented May 10, 2022 •
edited
Loading

#5468

Tests: TBD.

@github-actions github-actions bot added the A3-in_progress Pull request is in progress. No review needed at this stage. label May 10, 2022
@sandreim
fix typos
dde2c02 
Signed-off-by: Andrei Sandu <[email protected]>
sandreim added 3 commits May 11, 2022 09:21
@sandreim
Fix bounded sent metric
009c75e 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
refactor a bit and test
dcf9d87 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
Return disconnect errors early.
a839c25 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim sandreim added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels May 11, 2022
@sandreim sandreim marked this pull request as ready for review May 13, 2022 15:14
@sandreim sandreim added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels May 13, 2022
eskimor
eskimor approved these changes May 16, 2022
View reviewed changes
node/metered-channel/src/bounded.rs Outdated Show resolved Hide resolved
@sandreim
future proof error handling
c5873e1 
Signed-off-by: Andrei Sandu <[email protected]>
@eskimor
Copy link
Member

eskimor commented May 16, 2022

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for c5873e1

@sandreim
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit b79dccc into master May 17, 2022
@paritytech-processbot paritytech-processbot bot deleted the sandreim/bounded_send_blocks branch May 17, 2022 08:01
ordian added a commit that referenced this pull request May 17, 2022
@ordian
Merge branch 'master' into ao-disputes-offences-runtime
23494c6 
* master:
  Bump femme from 2.2.0 to 2.2.1 (#5534)
  Add counter for bounded channel sends that block. (#5490)
  Remove Duplicate Traits (#5536)
@ghzlatarev ghzlatarev mentioned this pull request Jul 29, 2022
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eskimor eskimor eskimor approved these changes

@tdimitrov tdimitrov tdimitrov approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandreim @eskimor @tdimitrov