Migrate xcm pallet to Named Events #5461
Conversation
|
This seems like a good idea to me as people can match on bits they are interested and |
|
@zqhxuyuan good progress! you are doing everything right. Just need to address the compiler errors, which is probably just migrating more event syntax to the new format |
|
done. |
xcm/pallet-xcm/src/lib.rs
Outdated
| /// | ||
| /// \[ id, response \] | ||
| ResponseReady(QueryId, Response), | ||
| ResponseReady { id: QueryId, response: Response }, |
There was a problem hiding this comment.
There's loads of ids in this world. I think it's really helpful to prefix it with the type of id it is. In this case query_id. (Shawn has done this in the prior PR for an index field and I think that's a good shout. There's lot's of indices too!)
gilescope
added
A0-please_review
|
No xcm changes outside the xcmv3 branch. If you want this to be merged, please change the target branch to xcmv3. |
follow up: #5422 on pallet-xcm