This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Use named events in cumulus pallets #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(I pulled in the latest polkadot master as well, possibly that was not required) |
|
Should we be calling things message_id or message_hash? Personally I think as it's not guaranteed to be unique we should be calling it what it is: a message hash. But there's an argument that it could change to something more unique in the future and then maybe message id is justified? |
gilescope
commented
May 14, 2022
bkchr
approved these changes
May 14, 2022
|
I'm inclided to rename |
joepetrowski
approved these changes
May 21, 2022
|
bot merge |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates cumulus pallets to use named events.
Partially fixes: paritytech/polkadot#5422
Reviewers please pay special attention to naming consistency with other naming event PRs:
paritytech/polkadot#5423
paritytech/polkadot#5461