Fix semver job by updating cargo toolchain #6283
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndWeHaveAPlan
approved these changes
Oct 30, 2024
alvicsam
approved these changes
Oct 30, 2024
ggwpez
reviewed
Oct 30, 2024
| workflow_dispatch: | ||
|
|
||
| concurrency: | ||
| group: check-semver-${{ github.event.pull_request.number || github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| env: | ||
| TOOLCHAIN: nightly-2024-06-01 |
There was a problem hiding this comment.
We needed to lock this to a specific nightly since the https://github.com/paritytech/parity-publish only supports a specific version.
Not sure if this will still work now.
There was a problem hiding this comment.
Hmm so there is a mapping between parity-publish and supported nightly? Disabled merge for now.
There was a problem hiding this comment.
Yea it uses some docs export feature from nighly, but it reads like the newest version can also handle stable: https://github.com/obi1kenobi/cargo-semver-checks/releases/tag/v0.36.0#:~:text=all%20stable%20Rust%20versions
Just need to update our parity tool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes here #6254 broke the semver job: https://github.com/paritytech/polkadot-sdk/actions/runs/11590030127/job/32266861391?pr=5891
Because it is using an old nightly without
PanicHookInfo. Attempting to fix this by changing to stable. We can also use newer nightly, but reasons for nightly are unclear to me currently.