Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semver job by updating cargo toolchain #6283

Closed
wants to merge 1 commit into from
Closed

Fix semver job by updating cargo toolchain #6283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/check-semver.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,23 @@ name: Check semver

on:
pull_request:
types: [opened, synchronize, reopened, ready_for_review]
types: [ opened, synchronize, reopened, ready_for_review ]
workflow_dispatch:

concurrency:
group: check-semver-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

env:
TOOLCHAIN: nightly-2024-06-01
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We needed to lock this to a specific nightly since the https://github.com/paritytech/parity-publish only supports a specific version.
Not sure if this will still work now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm so there is a mapping between parity-publish and supported nightly? Disabled merge for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea it uses some docs export feature from nighly, but it reads like the newest version can also handle stable: https://github.com/obi1kenobi/cargo-semver-checks/releases/tag/v0.36.0#:~:text=all%20stable%20Rust%20versions
Just need to update our parity tool.

TOOLCHAIN: stable

jobs:
preflight:
uses: ./.github/workflows/reusable-preflight.yml
check-semver:
runs-on: ubuntu-latest
timeout-minutes: 90
needs: [preflight]
needs: [ preflight ]
container:
image: ${{ needs.preflight.outputs.IMAGE }}
steps:
Expand Down
Loading