Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable2409] Backport #5655 #5800

Merged
merged 5 commits into from
Sep 24, 2024
Merged

[stable2409] Backport #5655 #5800

merged 5 commits into from
Sep 24, 2024

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]
Copy link

Backport #5655 into stable2409 from ggwpez.

See the documentation on how to use this bot.

@ggwpez @github-actions
[benchmarking] Reset to genesis storage after each run (#5655)
2b16af6 
The genesis state is currently partially provided via
`OverlayedChanges`, but these changes are reset by the runtime after the
first repetition, causing the second repitition to use an invalid
genesis state.

Changes:
- Provide the genesis state as a `Storage` without any
`OverlayedChanges` to make it work correctly with repetitions.
- Add `--genesis-builder-preset` option to use different genesis preset
names.
- Improve error messages.

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: ggwpez <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Branislav Kontur <[email protected]>
(cherry picked from commit 2e4e5bf)
@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Sep 22, 2024
Merged
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Sep 22, 2024
@github-actions GitHub Actions
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@ggwpez
Copy link
Member

ggwpez commented Sep 23, 2024

Sadly we cant backport this since it is a major bump, but it should be possible to do a point-release of the omni-bencher crate since it is quite freestanding.

@ggwpez ggwpez closed this Sep 23, 2024
@ggwpez ggwpez reopened this Sep 24, 2024
@ggwpez
Copy link
Member

ggwpez commented Sep 24, 2024

Actually should be fine since the release is not out yet.

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 1/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7424028

@ggwpez ggwpez merged commit af135b2 into stable2409 Sep 24, 2024
180 of 186 checks passed
@ggwpez ggwpez deleted the backport-5655-to-stable2409 branch September 24, 2024 20:51
@bkontur bkontur mentioned this pull request Sep 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggwpez ggwpez ggwpez approved these changes

Assignees
No one assigned
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggwpez @paritytech-cicd-pr