Make sure validator nodes can find each other #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate them as well if needed
pepyakin
force-pushed
the
pep-bootnodes
branch
from
c9ab3ed to
e9ebc5c
Compare
|
as with my previous PR #153 seems like prettier is already broken. |
|
In my case, relaychain (rococo-local) are always working great, I mean they can find each other, but after Polkadot 0.9.12, parachain are no longer find each other, even I port this PR for parachain PS: Chain type of parachain are UPDATE: I made a bug when I left the comment, after I fixed that, it looks parachain works, so I guess we need port this PR for parachain too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For unknown reasons my nodes refuse connecting to each other. This is not only me though apprently #77. There was an attempt to fix that by @JesseAbram, however, it never really landed.
So I just went ahead and implemented @bkchr's suggestion (at least my interpretation of it): do not wait for the node to start up and just embed the keys into the chainspec.
Specifically, the config gets a new parameter for a node:
nodeKey. This is a 32 byte hex encoded string, the same as you would put in--node-keyparameter when running a substrate node. In fact, we pass the node key with that flag upon spawning the validator nodes. In case the config does not specify node key, we just generate it. Then that nodeKey we construct a peer id, and use that to generate the boot nodes list. The boot nodes list assumes localhost/127.0.0.1.Since this PR adds new dependencies, I also updated the yarn.nix.