-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check_dependent_project: retrigger once the PR description changes #37
Comments
Could you please elaborate on how this works? |
Ah, okay, this is it, right? |
it's referring to https://github.com/paritytech/pipeline-scripts#step-2-detect-all-dependents and subsequent steps |
@joao-paulo-parity if there were 2 companions, and vanity-service added 2 red (failed) statuses. Then you remove one companion, and we re-triggered check_dependent_project - will the other status be automatically removed or ignored somehow? |
Naively, all companion checks should be retried since companions might be related to each other. e.g. if a PR has both Polkadot and Cumulus companions and I remove the Polkadot one, the Cumulus check should be rerun because the Polkadot companion matters for it. Optimally, we could have a smart script that can detect precisely which checks should be rerun based on what changed. I don't think it's necessary for us to go for the optimized version right now since description edits shouldn't happen often; it's better to have something suboptimal in the short term rather than a complete lack of the feature. |
Problem: paritytech/substrate#11148 was edited around 10 hours ago to no longer have a Cumulus companion
When that happened, however, the
check-dependent-cumulus
job was not run again.Solution: Run the
check-dependent-*
jobs once the PR description changes. This is justified because edits to the PR's description might change its dependency chain, which matters for those jobs.The text was updated successfully, but these errors were encountered: