Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_dependent_project: retrigger once the PR description changes #37

Closed
joao-paulo-parity opened this issue May 5, 2022 · 5 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@joao-paulo-parity
Copy link
Contributor

joao-paulo-parity commented May 5, 2022

Problem: paritytech/substrate#11148 was edited around 10 hours ago to no longer have a Cumulus companion

image

When that happened, however, the check-dependent-cumulus job was not run again.

Solution: Run the check-dependent-* jobs once the PR description changes. This is justified because edits to the PR's description might change its dependency chain, which matters for those jobs.

@joao-paulo-parity joao-paulo-parity added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels May 5, 2022
@mutantcornholio
Copy link
Contributor

edits to the PR's description might change its dependency chain, which matters for those jobs.

Could you please elaborate on how this works?

@mutantcornholio
Copy link
Contributor

Ah, okay, this is it, right?

@joao-paulo-parity
Copy link
Contributor Author

@joao-paulo-parity joao-paulo-parity added enhancement New feature or request bug Something isn't working and removed bug Something isn't working labels May 12, 2022
@joao-paulo-parity joao-paulo-parity changed the title check_dependent_project should be retriggered once the PR description changes check_dependent_project: retrigger once the PR description changes Jun 8, 2022
@mordamax
Copy link
Contributor

@joao-paulo-parity if there were 2 companions, and vanity-service added 2 red (failed) statuses. Then you remove one companion, and we re-triggered check_dependent_project - will the other status be automatically removed or ignored somehow?
let me know if it's not clear :) not sure if I explained it enough

@joao-paulo-parity
Copy link
Contributor Author

will the other status be automatically removed or ignored somehow?

Naively, all companion checks should be retried since companions might be related to each other. e.g. if a PR has both Polkadot and Cumulus companions and I remove the Polkadot one, the Cumulus check should be rerun because the Polkadot companion matters for it.

Optimally, we could have a smart script that can detect precisely which checks should be rerun based on what changed.

I don't think it's necessary for us to go for the optimized version right now since description edits shouldn't happen often; it's better to have something suboptimal in the short term rather than a complete lack of the feature.

@mordamax mordamax closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants