Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Stop the merge process once the dependency chain for a PR is modified #384

Closed
joao-paulo-parity opened this issue May 5, 2022 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@joao-paulo-parity
Copy link
Contributor

Problem: Suppose the following scenario

  1. I create a PR with two companions
polkadot companion: [link]
cumulus companion: [link]
  1. I say bot merge

  2. After bot merge has started, I edit the description of the PR to remove the cumulus companion

polkadot companion: [link]
-cumulus companion: [link]

Now there's a problem that the PR description is no longer matching the dependency chain computed at the start of bot merge.

Solution: stop the merge process once the dependency chain for a PR is modified. When that happens, post a comment "Error: PR dependency chain was modified" with a diff between old/new dependencies.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants