Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_dependent_project: handle companion PR changes #62

Closed
joao-paulo-parity opened this issue Jul 11, 2022 · 1 comment
Closed

check_dependent_project: handle companion PR changes #62

joao-paulo-parity opened this issue Jul 11, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@joao-paulo-parity
Copy link
Contributor

joao-paulo-parity commented Jul 11, 2022

Problem: suppose the usual scenario of a Substrate PR with a Polkadot companion PR. Since the check is on Substrate's pipeline, it will rerun when commits are pushed to the Substrate PR, but not when commits are pushed to the Polkadot PR. The same is true for description changes.

Solution: trigger the check-dependent-* jobs when any PR in the dependency chain incurs changes to their description or commits, not only the PR where the change happened.

For this we'll need to have some database for storing and querying the connections - that is, dependencies and dependents - for a given PR. Since connections are parsed from PRs' descriptions, we'll need to react to description changes (#37) which can be done through a GitHub Action or App. For the database we could try to leverage the CI/CD Redis instance (https://github.com/paritytech/ci_cd/wiki/GitLab:-Redis-for-GitLab-CI).

@joao-paulo-parity joao-paulo-parity added the enhancement New feature or request label Jul 11, 2022
@joao-paulo-parity joao-paulo-parity self-assigned this Jul 11, 2022
@joao-paulo-parity joao-paulo-parity changed the title check_dependent_project: handle companion PR commits check_dependent_project: handle companion PR changes Jul 11, 2022
@mordamax
Copy link
Contributor

mordamax commented Aug 30, 2022

I'd hesitate to iterate this through pipeline-scripts .sh file with 1,2k lines of code. The CBS should be re-designed & reimplemented at the right scale level, so it may include this kind of feature

This will be included in the design of the new CBS

image

@joao-paulo-parity joao-paulo-parity removed their assignment Oct 19, 2022
@mordamax mordamax closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants