Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rpc): remove FillableTransaction #8800

Merged
merged 108 commits into from
Jun 14, 2024
Merged

chore(rpc): remove FillableTransaction #8800

merged 108 commits into from
Jun 14, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Jun 13, 2024

Closes #8776.

  • Replaces use of trait FillableTransaction with existing method ConfigureEvmEnv::fill_tx_env
  • Adds self parameter to ConfigureEvmEnv::fill_tx_env signature, to make it callable by opaque types
  • Completes default ConfigureEvmEnv trait impl

blocked by #8799

emhane added 30 commits June 1, 2024 12:18
@emhane
Make on_blocking_task method accessible in default trait method impls
cab888f
@emhane
Minimise thread interface eth api
b902f35
@emhane
Update docs and symbol name
c35b40e
@emhane
Add missing reth primitives to op feature
8ccddd3
@emhane
Remove feature gate to fix broken test
257dc5d
@emhane
Fix flaky test
40194d6
@emhane
fixup! Fix flaky test
68e64b4
@emhane
fixup! Fix flaky test
30b63cc
@emhane
Update lock file
fcc64ea
@emhane
Reinsert functions for spawning blocking threads into EthTransactions
734ac99
@emhane
Drive-by, update docs
c000f43
@emhane
Move spawn cpu heavy to trait
d1b91ad
@emhane
Fix lint
eec99b8
@emhane
Revert impl for spawning blocking io
924024f
@emhane
Make impl of spawn blocking default trait methods
ea6cbd3
@emhane
Update docs
ecb6771
@emhane
Revert unrelated changes
fe494dc
@emhane
Merge branch 'main' into emhane/blocking-read
ba6f403
@emhane
Merge branch 'matt/scaffold-ethapi' into emhane/blocking-read
55d2649
@emhane
Merge branch 'matt/scaffold-ethapi' into emhane/blocking-read
139f97f
@emhane
Fix lint
8b8ed16
@emhane
Add super traits to spawn blocking
f3ed6bd
@emhane
Move impl of methods using evm config to default trait methods
16334cd
@emhane
Move EthApi state access methods into trait
20d2489
@emhane
Move EthTransaction impls to default trait methods
4a40032
@emhane
Move state rpc methods into new trait default impl
f2df915
@emhane
fixup! Move state rpc methods into new trait default impl
ca19811
@emhane
Move EthTransactions impl to default trait methods
8ee373c
@emhane
Add trait for pending block
6dfac1a
@emhane
Merge branch 'matt/scaffold-ethapi' into emhane/ethapi-txns
90f67b6
jsvisa and others added 16 commits June 13, 2024 16:17
@jsvisa @emhane
fix(rpc/trace): wrong calculate of block ommer rewards (#8767)
d98f190 
Signed-off-by: jsvisa <[email protected]>
@Rjected @emhane
feat: introduce reth benchmark command (#8284)
4119639 
Co-authored-by: Emilia Hane <[email protected]>
@PelleKrab @mattsse
@onbjerg @emhane
chore: remove HeaderSyncMode::Continuous & debug.continuous (#8714)
bb9309c 
Co-authored-by: Matthias Seitz <[email protected]>
Co-authored-by: Oliver Nordbjerg <[email protected]>
@mattsse @emhane
chore: bump version 1.0.0-rc.1 (#8775)
6206802
@mattsse @emhane
fix: prometheus graceful shutdown (#8784)
865b259
@joshieDo @mattsse @emhane
fix: add a 5 second timeout for tokio_runtime shutdown (#8771)
b2812bc 
Co-authored-by: Matthias Seitz <[email protected]>
@mattsse @emhane
fix: disable sysinfo multithreading (#8783)
bdea88c
@ibremseth @emhane
fix: separate Base Sepolia and OP Sepolia BASE_FEE_PARAMS (#8789)
48d5e95
@JackG-eth @emhane
feat: support no_std for reth-consensus (#8792)
1828340
@JackG-eth @mattsse @emhane
feat: support no_std for reth-storage-errors (#8790)
51382cf 
Co-authored-by: Matthias Seitz <[email protected]>
@Rjected @emhane
feat: log debug log directory on startup (#8785)
a3da827
@barnabasbusa @emhane
fix: migration of ethereum-package to ethpandaops (#8797)
01b900f
@shekhirin @Rjected
@onbjerg @emhane
docs(book): start documenting ExExes (#8779)
dd74832 
Co-authored-by: Dan Cline <[email protected]>
Co-authored-by: Oliver <[email protected]>
@emhane
Fix merge conflicts
f7b076d
@emhane
Simplify macro rule impl of EthApiServer building block traits, for t…
5c31258 
…ype with data layout like EthApi
@emhane
Merge branch 'matt/scaffold-ethapi' into emhane/optimism-api
81ae2cc
@emhane emhane changed the base branch from main to emhane/optimism-api June 13, 2024 14:56
@emhane emhane requested a review from onbjerg as a code owner June 13, 2024 14:56
DaniPopes
DaniPopes approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt

Base automatically changed from emhane/optimism-api to matt/scaffold-ethapi June 13, 2024 18:10
@emhane emhane removed the S-blocked This cannot more forward until something else changes label Jun 13, 2024
mattsse
mattsse approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emhane emhane merged commit 56ed575 into matt/scaffold-ethapi Jun 14, 2024
19 of 25 checks passed
@emhane emhane deleted the emhane/fillable-tx branch June 14, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

@joshieDo joshieDo Awaiting requested review from joshieDo

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove FillableTransaction trait