fix(rpc/trace): wrong calculate of block ommer rewards #8767
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation of
trace_block
rpc, we return block base reward asblock
reward, and the uncle inclusion rewards asuncle
reward.But in OpenEthereum/Erigon's implementation, they return
block base + uncle inclusion
asblock
reward, and each uncle reward asuncle
reward, so the actual uncle rewards were missed.IMHO, we should keep the same as oe/erigon, because the results will be more inaccurate, similar to etherscan's.
Eg the reward of https://etherscan.io/block/1378035
Reth's response:
Erigon's response
Ref https://github.com/ledgerwatch/erigon/blob/b4c9f22923cd7156cd26be91a8a83b131eb3cc73/consensus/ethash/consensus.go#L624-L668