Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse alloy-eips constants #6540

Merged
merged 3 commits into from
Feb 11, 2024

Conversation

ThreeHrSleep
Copy link
Contributor

closes #6489


/// Commitment version of a KZG commitment
pub const VERSIONED_HASH_VERSION_KZG: u8 = 0x01;
pub use alloy_eips::eip4844::*;
Copy link
Collaborator

@mattsse mattsse Feb 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want this to be exhaustive, so we can see directly what we have available. this makes it slightly easier to navigate.

so replace * with all constants

@mattsse mattsse added the C-debt A clean up/refactor of existing code label Feb 11, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

@mattsse mattsse enabled auto-merge February 11, 2024 14:43
@mattsse mattsse added this pull request to the merge queue Feb 11, 2024
Merged via the queue into paradigmxyz:main with commit 0d10af4 Feb 11, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt A clean up/refactor of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reuse alloy-eips constants
2 participants