Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reuse alloy-eips constants #6489

Closed
mattsse opened this issue Feb 8, 2024 · 2 comments · Fixed by #6540
Closed

reuse alloy-eips constants #6489

mattsse opened this issue Feb 8, 2024 · 2 comments · Fixed by #6540
Assignees
@ThreeHrSleep
Labels
C-debt A clean up/refactor of existing code C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Feb 8, 2024

Describe the feature

alloy's eips crate has a bunch of duplicated constants that we can re-export

in

https://github.com/paradigmxyz/reth/blob/672246d40062d29985b0dabc21ba523e4971ccfd/crates/primitives/src/constants/eip4844.rs

from

https://github.com/alloy-rs/alloy/blob/1737429f1f50fe7cb8aacc070831088bf3290320/crates/eips/src/eip4844.rs

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started C-debt A clean up/refactor of existing code labels Feb 8, 2024
@ThreeHrSleep
Copy link
Contributor

Can I take this on?

@mattsse
Copy link
Collaborator Author

mattsse commented Feb 8, 2024

assigned!

@i-m-aditya i-m-aditya mentioned this issue Feb 8, 2024
Closed
@ThreeHrSleep ThreeHrSleep mentioned this issue Feb 10, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThreeHrSleep ThreeHrSleep

Labels
C-debt A clean up/refactor of existing code C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

reuse alloy-eips constants ThreeHrSleep/reth
reuse alloy eips constants i-m-aditya/reth
2 participants
@mattsse @ThreeHrSleep