Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: only record return value if required #3040

Merged
merged 6 commits into from
Jul 5, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jun 6, 2023

Blocked by bluealloy/revm#509

this will only record the call's output if configured

prep for #3032

@mattsse mattsse marked this pull request as draft June 6, 2023 21:50
@mattsse mattsse added C-perf A change motivated by improving speed, memory usage or disk footprint A-rpc Related to the RPC implementation S-blocked This cannot more forward until something else changes labels Jun 6, 2023
@onbjerg onbjerg removed the S-blocked This cannot more forward until something else changes label Jun 8, 2023
@onbjerg
Copy link
Member

onbjerg commented Jun 8, 2023

Blocking PR merged, marking as unblocked @mattsse

@mattsse mattsse marked this pull request as ready for review June 12, 2023 14:00
@mattsse mattsse added the S-blocked This cannot more forward until something else changes label Jun 13, 2023
@mattsse
Copy link
Collaborator Author

mattsse commented Jun 13, 2023

this is still blocked because revm has two branches and the feature we need here is on main but we pull in release/v25

@github-actions github-actions bot added the Stale label Jul 4, 2023
@onbjerg onbjerg removed the Stale label Jul 5, 2023
@mattsse mattsse requested a review from Rjected as a code owner July 5, 2023 13:10
@mattsse
Copy link
Collaborator Author

mattsse commented Jul 5, 2023

@onbjerg unblocked by copying the unreleased function to unblock this

@mattsse mattsse removed the S-blocked This cannot more forward until something else changes label Jul 5, 2023
@mattsse mattsse requested a review from onbjerg July 5, 2023 13:11
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #3040 (a42fce5) into main (ceb4e35) will decrease coverage by 0.03%.
The diff coverage is 5.88%.

Impacted file tree graph

Impacted Files Coverage Δ
...s/revm/revm-inspectors/src/tracing/builder/geth.rs 0.00% <0.00%> (ø)
crates/revm/revm-inspectors/src/tracing/mod.rs 0.00% <0.00%> (ø)
crates/revm/revm-inspectors/src/tracing/types.rs 0.00% <ø> (ø)
crates/rpc/rpc/src/debug.rs 11.06% <0.00%> (ø)
crates/rpc/rpc/src/eth/revm_utils.rs 36.33% <0.00%> (-0.65%) ⬇️
crates/revm/revm-inspectors/src/tracing/config.rs 26.76% <33.33%> (+0.28%) ⬆️

... and 9 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.10% <5.88%> (-0.02%) ⬇️
unit-tests 63.96% <5.88%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 26.41% <ø> (ø)
blockchain tree 81.25% <ø> (ø)
pipeline 86.91% <ø> (ø)
storage (db) 73.48% <ø> (ø)
trie 95.09% <ø> (ø)
txpool 49.11% <ø> (-0.09%) ⬇️
networking 77.86% <ø> (-0.07%) ⬇️
rpc 58.02% <0.00%> (-0.02%) ⬇️
consensus 62.69% <ø> (ø)
revm 34.96% <14.28%> (+<0.01%) ⬆️
payload builder 6.83% <ø> (ø)
primitives 88.29% <ø> (+<0.01%) ⬆️

crates/rpc/rpc/src/eth/revm_utils.rs Outdated Show resolved Hide resolved
@onbjerg onbjerg enabled auto-merge July 5, 2023 14:14
@onbjerg onbjerg added this pull request to the merge queue Jul 5, 2023
Merged via the queue into main with commit e7cedee Jul 5, 2023
@onbjerg onbjerg deleted the matt/only-record-return-value-if-required branch July 5, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants