Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug_traceTransaction enableReturnData should be ignored for RPC responses #3032

Closed
mattsse opened this issue Jun 6, 2023 · 6 comments
Closed

debug_traceTransaction enableReturnData should be ignored for RPC responses #3032

mattsse opened this issue Jun 6, 2023 · 6 comments
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity

Comments

@mattsse
Copy link
Collaborator

mattsse commented Jun 6, 2023

Describe the feature

the response type StructLogRes doesn't even include a returnData field, and this is only used for local debugging.

It should simply be ignored so we don't capture return data that we don't need

it's only used for debug_standardTraceBlockToFile and debug_standardTraceBadBlockToFile rpc calls

TODO

  • document extra fields in StructLog type (StructLogRes)
  • ignore enableReturnData setting for regular debug_trace calls that return RPC

is this correct @shekhirin ?

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Jun 6, 2023
@mattsse mattsse added A-rpc Related to the RPC implementation and removed S-needs-triage This issue needs to be labelled labels Jun 6, 2023
@shekhirin
Copy link
Collaborator

Yes, that sounds right!

@mattsse mattsse mentioned this issue Jun 6, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Jul 4, 2023
@shekhirin
Copy link
Collaborator

@mattsse is this still relevant?

@mattsse
Copy link
Collaborator Author

mattsse commented Jul 4, 2023

yeah, the pr is still blocked because revm pr is not included in the patch.
I could finish it though with some extra code though, I think I'll just do that

@shekhirin shekhirin removed the S-stale This issue/PR is stale and will close with no further activity label Jul 4, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Jul 31, 2023
@mattsse mattsse added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Jul 31, 2023
@mattsse mattsse added the D-good-first-issue Nice and easy! A great choice to get started label Oct 2, 2023
@mattsse
Copy link
Collaborator Author

mattsse commented Oct 18, 2023

actually, since enableReturnData is opt-in, it would be more effort to remove support for it in the regular rpc calls

@mattsse mattsse closed this as completed Oct 18, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shekhirin @mattsse