feat(rpc): define traits for stateless APIs #13016
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xecuteStatelessPayload APIs
syjn99
changed the title
This was referenced Nov 29, 2024
mattsse
requested changes
Dec 2, 2024
Comment on lines
+340
to
+348
| /// Post Prague payload handler | ||
| #[method(name = "executeStatelessPayloadV4")] | ||
| async fn execute_stateless_payload_v4( | ||
| &self, | ||
| payload: ExecutionPayloadV3, | ||
| versioned_hashes: Vec<B256>, | ||
| parent_beacon_block_root: B256, | ||
| execution_requests: Requests, | ||
| ) -> RpcResult<PayloadStatus>; |
There was a problem hiding this comment.
this function no longer exists
Comment on lines
+327
to
+333
| #[method(name = "executeStatelessPayloadV3")] | ||
| async fn execute_stateless_payload_v3( | ||
| &self, | ||
| payload: ExecutionPayloadV3, | ||
| versioned_hashes: Vec<B256>, | ||
| parent_beacon_block_root: B256, | ||
| ) -> RpcResult<PayloadStatus>; |
There was a problem hiding this comment.
how is this different from the existing payloadv3 function?
There was a problem hiding this comment.
You're right, it is same as new_payload_vx methods rn. I have a question about the scope of this PR: It seems new structs need to be defined(as I mentioned at alloy#12766), so I planned to touch the function signature after those structs are ready(I'm happy to be assigned to that issue also).
Is there any good way to note that this method is not yet implemented? Or could you elaborate the scope more if I understood wrong?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12766.