Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for engine_executeStatelessPayloadVX Engine RPCs #12766

Open
Akagi201 opened this issue Nov 22, 2024 · 7 comments
Open

Add support for engine_executeStatelessPayloadVX Engine RPCs #12766

Akagi201 opened this issue Nov 22, 2024 · 7 comments
Assignees
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@Akagi201
Copy link

Akagi201 commented Nov 22, 2024

Describe the feature

engine_executeStatelessPayloadV1,engine_executeStatelessPayloadV2,engine_executeStatelessPayloadV3,engine_executeStatelessPayloadV4, engine RPC methods are already implemented in go-ethereum node, which is useful to execute a witness data to calculate block header fields.

Additional context

No response

@Akagi201 Akagi201 added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Nov 22, 2024
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started and removed S-needs-triage This issue needs to be labelled labels Nov 26, 2024
@mattsse
Copy link
Collaborator

mattsse commented Nov 26, 2024

makes sense,

first we need a new rpc trait that defines the functions for this similar to:

pub trait EngineApi<Engine: EngineTypes> {

@mattsse mattsse added the A-rpc Related to the RPC implementation label Nov 26, 2024
@syjn99
Copy link
Contributor

syjn99 commented Nov 26, 2024

I'd love to take this

@mattsse
Copy link
Collaborator

mattsse commented Nov 26, 2024

assigned

@syjn99
Copy link
Contributor

syjn99 commented Nov 28, 2024

Hi @mattsse I'm investigating this work for a couple of hours, and I'd like to ask some questions for implementing this api.

Thank you so much for your effort!

@mattsse
Copy link
Collaborator

mattsse commented Nov 28, 2024

I see, I think these are very similar to debug_executionWitness, I kinda prefer geth's naming here actually.

so for the first pr, let's define all of those, but only define the traits first.
implementation is more tricky and we can tackle this in followups

@syjn99
Copy link
Contributor

syjn99 commented Nov 28, 2024

Got it. Worried about my pr being too heavy for implementing all the things, but it will be fine if I only define the traits first. Thank you @mattsse

@syjn99
Copy link
Contributor

syjn99 commented Nov 29, 2024

gm @mattsse, I've just committed draft pr (#13016), and raised an issue to alloy for further implementation(alloy#1707).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Status: Todo
Development

No branches or pull requests

3 participants