Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: block_with_senders on BlockState #11363

Merged
merged 2 commits into from
Oct 1, 2024
Merged

dev: block_with_senders on BlockState #11363

merged 2 commits into from
Oct 1, 2024

Conversation

greged93
Copy link
Contributor

@greged93 greged93 commented Oct 1, 2024 •
edited
Loading

Adds block_with_senders(&self) -> BlockWithSenders and sealed_block_with_senders(&self) -> SealedBlockWithSenders on BlockState.

Resolves #11342

mattsse
mattsse approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty, lgtm

blocked until #11332

@mattsse mattsse added the C-enhancement New feature or request label Oct 1, 2024
@mattsse mattsse enabled auto-merge October 1, 2024 13:28
@mattsse mattsse added this pull request to the merge queue Oct 1, 2024
Merged via the queue into paradigmxyz:main with commit 15e3e0e Oct 1, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify BlockState to (Sealed)BlockWithSenders
2 participants
@greged93 @mattsse