Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify BlockState to (Sealed)BlockWithSenders #11342

Closed
mattsse opened this issue Sep 30, 2024 · 1 comment · Fixed by #11363
Closed

Simplify BlockState to (Sealed)BlockWithSenders #11342

mattsse opened this issue Sep 30, 2024 · 1 comment · Fixed by #11363
Assignees
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Sep 30, 2024

Describe the feature

currently we do this a lot:

let block = block_state.block().block().clone();
let senders = block_state.block().senders().clone();
BlockWithSenders { block: block.unseal(), senders }

we could simplify this with a function on BlockState that is

fn block_with_senders(&self) -> BlockWithSenders

this will require internal clones but this is fine

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started labels Sep 30, 2024
@greged93
Copy link
Contributor

greged93 commented Sep 30, 2024

hey Matt I'd like to work on this if possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants