chore(trie): replace ParallelStateRoot with AsyncStateRoot #11213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgimenez
requested review from
rkrasiuk,
Rjected and
mattsse
as code owners
DaniPopes
reviewed
Sep 25, 2024
DaniPopes
approved these changes
Sep 25, 2024
rkrasiuk
reviewed
Sep 26, 2024
rkrasiuk
approved these changes
Sep 26, 2024
fgimenez
force-pushed
the
fgimenez/rename-async-parallel-state-root
branch
from
12365f7 to
456db3b
Compare
fgimenez
force-pushed
the
fgimenez/rename-async-parallel-state-root
branch
from
456db3b to
a55dc13
Compare
ZanCorDX
added a commit
to flashbots/rbuilder
that referenced
this pull request
Nov 28, 2024
## 📝 Summary - Dependency hell. - In lots of generics (eg:ProviderFactory) the need of DB+Spec was replaced for NodeTypesWithDB. - DatabaseProviderFactory DB now is asociated type and have 2 more. In lots of places now we need Provider: BlockReader. - Lots of types moved to alloy_primitives. - encode/decode_enveloped now are XXX_2718 with minimal changes. - New alloy TrieNode::EmptyRoot . - CachedReads moved to reth::revm::cached. - AsyncStateRoot replaced by ParallelStateRoot (paradigmxyz/reth#11213). - Some HashMap/Set changed to custom versions (eg: alloy_primitives::map::HashMap). - TransactionPool needs stronger restrictions on Transaction. - Updated block finalization (pectra). - Pectra relay submition. ## 💡 Motivation and Context - We needed this for Pectra and to be up to date with reth. - My life was going so well that I needed something to balance it so I did this boring PR. ## ✅ I have completed the following steps: * [X] Run `make lint` * [X] Run `make test` * [ ] Added tests (if applicable) --------- Co-authored-by: Liam Aharon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #10927
tokio::sync::oneshotchannels used for synchronization inAsyncStateRootwere replaced by sync versions because we were awaiting results in order and the overhead of setting up and using the tokio runtime was not giving any benefit. With these changes,AsyncStateRootis no longer async.Given that
ParallelStateRootis not used and thatAsyncStateRootis an optimization over it keeping its parallel nature, in this PR the currentParallelStateRootis removed, andAsyncStateRootis renamed toParallelStateRoot.