Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(engine): migrate to AsyncStateRoot #10927

Merged
merged 18 commits into from
Sep 25, 2024
Merged

perf(engine): migrate to AsyncStateRoot #10927

merged 18 commits into from
Sep 25, 2024

Conversation

fgimenez
Copy link
Member

@fgimenez fgimenez commented Sep 16, 2024 •
edited
Loading

Closes: #10892

Uses AsyncStateRoot instead of ParallelStateRoot to calculate the state root.

@rkrasiuk
Copy link
Member

depends on #10920

@rkrasiuk rkrasiuk added C-perf A change motivated by improving speed, memory usage or disk footprint A-consensus Related to the consensus engine A-trie Related to Merkle Patricia Trie implementation labels Sep 16, 2024
@rkrasiuk rkrasiuk added the S-needs-benchmark This set of changes needs performance benchmarking to double-check that they help label Sep 16, 2024
@rkrasiuk
Copy link
Member

let's get some numbers in and then we can merge

@fgimenez fgimenez requested a review from onbjerg as a code owner September 16, 2024 10:15
@fgimenez fgimenez force-pushed the fgimenez/migrate-to-async-state-root branch from 090f3f9 to 4361936 Compare September 16, 2024 10:52
@fgimenez fgimenez requested a review from rakita as a code owner September 16, 2024 12:46
@fgimenez fgimenez force-pushed the fgimenez/migrate-to-async-state-root branch 2 times, most recently from d48d36f to 0a0b475 Compare September 17, 2024 07:53
rkrasiuk
rkrasiuk requested changes Sep 17, 2024
View reviewed changes
crates/engine/tree/src/tree/mod.rs Outdated Show resolved Hide resolved
@fgimenez fgimenez requested a review from gakonst as a code owner September 18, 2024 13:05
@fgimenez fgimenez force-pushed the fgimenez/migrate-to-async-state-root branch 4 times, most recently from 550465e to d59dfdb Compare September 22, 2024 18:36
mattsse
mattsse requested changes Sep 23, 2024
View reviewed changes
crates/engine/tree/src/tree/mod.rs Outdated Show resolved Hide resolved
crates/engine/tree/src/tree/mod.rs Outdated Show resolved Hide resolved
@fgimenez fgimenez force-pushed the fgimenez/migrate-to-async-state-root branch from d59dfdb to dc51182 Compare September 24, 2024 08:40
@fgimenez fgimenez requested a review from rkrasiuk September 24, 2024 09:31
@rkrasiuk rkrasiuk mentioned this pull request Sep 24, 2024
Open
@rkrasiuk rkrasiuk requested a review from mattsse September 24, 2024 16:17
@rkrasiuk
Copy link
Member

rkrasiuk commented Sep 24, 2024 •
edited
Loading

we can consider renaming async roots

rkrasiuk
rkrasiuk approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@rkrasiuk rkrasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fgimenez
Copy link
Member Author

we can consider renaming async roots

indeed, not async anymore, will do in a follow-up

mattsse
mattsse approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fgimenez fgimenez added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit 1e0a35e Sep 25, 2024
35 checks passed
@fgimenez fgimenez deleted the fgimenez/migrate-to-async-state-root branch September 25, 2024 12:48
@fgimenez fgimenez mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@gakonst gakonst Awaiting requested review from gakonst

Assignees
No one assigned
Labels
A-consensus Related to the consensus engine A-trie Related to Merkle Patricia Trie implementation C-perf A change motivated by improving speed, memory usage or disk footprint S-needs-benchmark This set of changes needs performance benchmarking to double-check that they help
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

perf(engine): migrate to AsyncStateRoot
3 participants
@fgimenez @rkrasiuk @mattsse