Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(provider): entries by tx range for BlockchainProvider2 #10305

Closed
wants to merge 14 commits into from
Closed

feat(provider): entries by tx range for BlockchainProvider2 #10305

wants to merge 14 commits into from

Conversation

shekhirin
Copy link
Collaborator

Addresses #10182 and #10181, but only parts with range queries

@shekhirin shekhirin added C-enhancement New feature or request A-db Related to the database A-engine Related to the engine implementation labels Aug 14, 2024
@shekhirin shekhirin force-pushed the alexey/entries-by-tx-range branch from 1e61342 to 1912fc5 Compare August 14, 2024 19:07
@shekhirin shekhirin force-pushed the alexey/entries-by-tx-range branch from 4dfd2ba to 685c775 Compare August 14, 2024 19:16
@shekhirin shekhirin marked this pull request as ready for review August 14, 2024 19:26
@shekhirin shekhirin force-pushed the alexey/entries-by-tx-range branch 2 times, most recently from 9e58d63 to ac38e67 Compare August 14, 2024 19:27
@shekhirin shekhirin force-pushed the alexey/entries-by-tx-range branch from ac38e67 to 65f26a0 Compare August 14, 2024 19:27
@shekhirin shekhirin requested a review from fgimenez August 15, 2024 18:14
fgimenez
fgimenez approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thanks!

Base automatically changed from alexey/blockchain-provider-receipt-id to main August 15, 2024 19:34
@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Sep 6, 2024
@github-actions github-actions bot closed this Sep 13, 2024
@shekhirin shekhirin added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Sep 13, 2024
@shekhirin shekhirin reopened this Sep 13, 2024
emhane
emhane reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@emhane emhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is the test coverage for this, or is it pending impl?

@shekhirin shekhirin closed this Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emhane emhane emhane left review comments

@fgimenez fgimenez fgimenez approved these changes

@Rjected Rjected Awaiting requested review from Rjected

@mattsse mattsse Awaiting requested review from mattsse

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

Assignees
No one assigned
Labels
A-db Related to the database A-engine Related to the engine implementation C-enhancement New feature or request M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shekhirin @fgimenez @emhane