Hive Test Failure: ethereum/rpc-compat

[github-actions]

!!!!!!! This is an automated issue created by the hive test failure !!!!!!!

The hive test for ethereum/rpc-compat failed. Please investigate and fix the issue.

Link to the failed run

[greged93]

Hey, can I have this one?

[greged93]

Ongoing progress:

• debug_getRawBlock/get-invalid-number: additional data field in the returned error. Proposed solution: PR on hive repo in order to skip the data field as well.
• debug_getRawHeader/get-invalid-number: additional data field in the returned error. Proposed solution: PR on hive repo in order to skip the data field as well.
• debug_getRawReceipts/get-invalid-number: additional data field in the returned error. Proposed solution: PR on hive repo in order to skip the data field as well.
• debug_getRawReceipts/get-block-n: incorrect RLP encoding. Fixed in fix: eth_getRawReceipts #7101.
• debug_getRawTransaction/get-invalid-hash: returns null instead of error with code -32602. The passed transaction hash doesn't start with 0x which should cause an error (geth returns message invalid argument 0: json: cannot unmarshal hex string without 0x prefix into Go value of type common.Hash). Decided that the test can be left failing.
• eth_call/call-callenv: incorrect call output.
• eth_estimateGas/estimate-successful-call: incorrect gas estimation. Fixed in fix: estimate gas #7133.
• eth_feeHistory/fee-history: incorrect baseFeePerBlobGas and blobGasUsedRatio.
• eth_getBlockReceipts/get-block-receipts-by-hash: missing blobGasPrice. Fixed in fix: receipt for non EIP-4844 transactions #7129.
• eth_getBlockReceipts/get-block-receipts-latest: missing blobGasPrice. Fixed in fix: receipt for non EIP-4844 transactions #7129.
• eth_getBlockReceipts/get-block-receipts-n: missing blobGasPrice. Fixed in fix: receipt for non EIP-4844 transactions #7129.
• eth_getProof/get-account-proof-blockhash: returns "unable to compute state root on top of historical block".
• eth_getProof/get-account-proof-with-storage: incorrect serialization for JsonStorageKey, fixed in fix: early return for JsonStorageKey to String alloy-rs/alloy#261.
• eth_getStorageAt/get-storage-invalid-key-too-large: expected error code -32000, but due to deserialization using JsonStorageKey, returns the storage at key 0x0.
• eth_getStorageAt/get-storage-invalid-key: expected error code -32000 got -32602.
• eth_getTransactionReceipt/get-access-list: missing blobGasPrice. Fixed in fix: receipt for non EIP-4844 transactions #7129.
• eth_getTransactionReceipt/get-dynamic-fee: missing blobGasPrice. Fixed in fix: receipt for non EIP-4844 transactions #7129.
• eth_getTransactionReceipt/get-legacy-contract: missing blobGasPrice. Fixed in fix: receipt for non EIP-4844 transactions #7129.
• eth_getTransactionReceipt/get-legacy-input: missing blobGasPrice. Fixed in fix: receipt for non EIP-4844 transactions #7129.
• eth_getTransactionReceipt/get-legacy-receipt: missing blobGasPrice. Fixed in fix: receipt for non EIP-4844 transactions #7129.

[Rjected]

Ongoing progress:

* [ ]  debug_getRawBlock/get-invalid-number: additional `data` field in the returned error. Proposed solution: PR on [hive](https://github.com/ethereum/hive/tree/master) repo in order to skip the `data` field as well.

* [ ]  debug_getRawHeader/get-invalid-number: additional `data` field in the returned error. Proposed solution: PR on [hive](https://github.com/ethereum/hive/tree/master) repo in order to skip the `data` field as well.

* [ ]  debug_getRawReceipts/get-invalid-number: additional `data` field in the returned error. Proposed solution: PR on [hive](https://github.com/ethereum/hive/tree/master) repo in order to skip the `data` field as well.

* [ ]  debug_getRawTransaction/get-invalid-hash: returns `null` instead of error with code `-32602`. The passed transaction hash doesn't start with `0x` which should cause an error (`geth` returns message `invalid argument 0: json: cannot unmarshal hex string without 0x prefix into Go value of type common.Hash`).

* [ ]  eth_call/call-callenv: incorrect call output.

* [ ]  eth_estimateGas/estimate-successful-call: incorrect gas estimation.

* [ ]  eth_feeHistory/fee-history: incorrect `baseFeePerBlobGas` and `blobGasUsedRatio`.

* [ ]  eth_getBlockReceipts/get-block-receipts-by-hash: missing `blobGasPrice`.

* [ ]  eth_getBlockReceipts/get-block-receipts-latest: missing `blobGasPrice`.

* [ ]  eth_getBlockReceipts/get-block-receipts-n: missing `blobGasPrice`.

* [ ]  eth_getProof/get-account-proof-blockhash: returns `"unable to compute state root on top of historical block"`.

* [x]  eth_getProof/get-account-proof-with-storage: incorrect serialization for `JsonStorageKey`, fixed in [fix: early return for `JsonStorageKey` to `String` alloy-rs/alloy#261](https://github.com/alloy-rs/alloy/pull/261).

* [ ]  eth_getStorageAt/get-storage-invalid-key-too-large: expected error code `-32000`, but due to deserialization using `JsonStorageKey`, returns the storage at key 0x0.

* [ ]  eth_getStorageAt/get-storage-invalid-key: expected error code `-32000` got ` -32602`.

* [ ]  eth_getTransactionReceipt/get-access-list: missing `blobGasPrice`.

* [ ]  eth_getTransactionReceipt/get-dynamic-fee: missing `blobGasPrice`.

* [ ]  eth_getTransactionReceipt/get-legacy-contract: missing `blobGasPrice`.

* [ ]  eth_getTransactionReceipt/get-legacy-input: missing `blobGasPrice`.

* [ ]  eth_getTransactionReceipt/get-legacy-receipt: missing `blobGasPrice`.

hey, re: skipping the data field on hive, it was advised here:
ethereum/hive#975 (comment)

that we should not be using the data field in the first place, see:
#6332

as well.

[greged93]

hey, re: skipping the data field on hive, it was advised here

Not sure how we can avoid to provide this data field then, as it comes from the rpc proc-macro.

[mattsse]

eth_getTransactionReceipt/get-access-list: missing blobGasPrice.

maybe those should be null and not skipped if None

https://github.com/alloy-rs/alloy/blob/05d0d0eb61e93e44c491ee0e7d82a4de5e0efb56/crates/rpc-types/src/eth/transaction/receipt.rs#L27-L31