simulators/rpc-compat: allow for any message in error checks #975
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reth runs the
rpc-compat
tests which expect an error, sometimes the error test vector contains a string like this:+ "message": "invalid argument 0: json: cannot unmarshal hex string without 0x prefix into Go value of type common.Hash
This is something that reth will never be able to output.
Sometimes we also see the following situation:
While this is a different way of displaying the error, it includes the correct error code and "invalid params" plus the
data
field give the right information.This PR tries to make sure that the deep comparison is still performed for the error object, with the exception of the
message
anddata
fields are not compared.cc @fjl, I pulled this from our old reth PR