-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move error data from error.data
to error.message
for failing rpc-compat calls
#6332
Comments
This issue is stale because it has been open for 21 days with no activity. |
so this originates from here you mean @Rjected ? reth/crates/rpc/rpc/src/eth/error.rs Lines 408 to 422 in de6332b
and the solution is: control that the output field on reth/crates/rpc/rpc/src/eth/error.rs Lines 491 to 500 in de6332b
links to where in specs the errors can be found? |
there are no specs for rpc errors, the hive tests are considered the spec more or less We basically cannot use the reth/crates/rpc/rpc/src/result.rs Lines 137 to 140 in fadc7b0
|
Describe the feature
ref ethereum/hive#975 (comment)
We should, where possible, prevent using the
error.data
field if the error message can be contained in theerror.message
field.This includes, but is not limited to
debug_getRawReceipts
.Analyzing the
rpc-compat
suite failures is the best way to understand every call that needs a change in error message:https://github.com/paradigmxyz/reth/actions/runs/7734052427/job/21088043313
Additional context
No response
The text was updated successfully, but these errors were encountered: