Fix conflicting keybindings on Gnome 42 #538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d signature" This reverts commit 1ac33b4.
Lythenas
changed the title
Lythenas
changed the title
|
Thanks @Lythenas! Unfortunately this PR also adds code that was never in versions prior to Gnome 44 (and never intended to be in previous versions) - and was only implemented as a temporary workaround since keybind clash detection in Gnome 44 was broken at the time (since fixed). The only line/reversion needed in this PR is this line. Closing this PR in favour of #539 since that one will implement a fix that is backwards compatible and works in Gnome 44, 43, 42. Note: I'm also planning on adding changes in #539 to develop branch - hopefully bringing us closer to |
jtaala
added a commit
that referenced
this pull request
May 30, 2023
… earlier) keybind clash detection (#539) See #537 #538 PR's which reverts changes that were backported to Gnome 43/42. This PR is a replacement for these individual reverts PRs. This PR implements a fix which first checks the number elements returned from Gtk.accelerator_parse (whether 2 or 3) and assigns them correctly. This is a much better/robust fix that means that this should now work regardless of what gnome version is used. Fixes #533, #536. The issue was caused by Gtk.accelerator_parse result changing in Gnome 44. There is confusion about when this change occurred, e.g. [GJS porting guide](https://gjs.guide/extensions/upgrading/gnome-shell-40.html#gtk-accelerator-parse) suggests this change occurred in Gnome 40, however actually testing in Fedora 37 (and purportedly in other Gnome 43, 42) versions it's still returning 2 elements instead of 3. This PR addresses both cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert the one commit that fixed conflicting keybindings on Gnome 44 from #515
Fixes #536
Notes regarding testing: You need to relogin after you enable conflicting keybindings. They don't seem to be picked up without relogin if you reset your keybindings in the Gnome settings.