Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keybind fails #536

Closed
eliorc opened this issue May 29, 2023 · 5 comments · Fixed by #539
Closed

Keybind fails #536

eliorc opened this issue May 29, 2023 · 5 comments · Fixed by #539
Labels
bug Undesirable behavior

Comments

@eliorc
Copy link

eliorc commented May 29, 2023

Describe the bug
Some keybinds fail. For example Super+Right can navigate to the right, Super+Left does nothing. Before uninstalling and installing all over again, also Super+Page Down worked while Super+Page Up didn't. This is accompanied by a weird topbar visualization bug

To Reproduce
Steps to reproduce the behavior:

  1. uninstall by executing ./uninstall
  2. As it still appears in the extension menu, manually delete it from there
  3. Reinstall from scratch, without restoring previous settings
  4. Open two windows
  5. Navigate right (Super+Right)
  6. Try to navigate left (Super+Left) - fail

Expected behavior
That super + left will work as well

Screenshots
Maybe its relevant but the top bar gets "highlighted" relatively to the active window, in this image the left window is in focus
image

System information:
Please execute ./gather-system-info.sh in you PaperWM clone and paste the output below.

Example:
Distribution: Ubuntu
GNOME Shell 42.5
Display server: Wayland
PaperWM branch/tag: gnome-42
PaperWM commit: 9a1611a23c30386f1b6b7ce148470d96f47b730c
Enabled extensions:
- paperwm@hedning:matrix.org
- [email protected]
- [email protected]

Additional context
None
@eliorc eliorc added the bug Undesirable behavior label May 29, 2023
@Lythenas
Copy link
Collaborator

This might be the same issue I ran into on gnome 43: #533

Regarding the topbar: This is a new feature. See https://github.com/paperwm/PaperWM#window-position-bar-colored-bar-segment-in-top-bar

@eliorc
Copy link
Author

eliorc commented May 29, 2023

Oh, good to know regarding the topbar 👍🏼

@Lythenas Lythenas mentioned this issue May 29, 2023
Closed
@jtaala jtaala mentioned this issue May 29, 2023
Merged
@jtaala
Copy link
Collaborator

jtaala commented May 29, 2023 •
edited
Loading

Thanks @eliorc!

Hey all, big thanks to @Lythenas for testing this out and creating some PRs.

I've now implemented a multi-gnome version fix/PR that should fix this once and for all (in all gnome versions) - see #539 for details.

@eliorc can you please test this PR/branch. I've testing on Gnome 43 (just bit the bullet and installed a 43 vm) and also Gnome 44.

NOTE: I know it mentions gnome43 in the branch name but this should also work for Gnome 42 just fine.

git fetch --all
git checkout fix-regression-gnome43-keybindclash
./install.sh

and then logout/login.

Thanks

@jtaala
Copy link
Collaborator

jtaala commented May 29, 2023

P.S. hopefully you like the window position-bar (I'm hoping since I spent a lot of time on it!) - however, if you don't like it you can turn it off in the paperwm extension settings or via terminal with:

dconf write /org/gnome/shell/extensions/paperwm/show-window-position-bar false

@jtaala jtaala linked a pull request May 29, 2023 that will close this issue
REGRESSION FIX: Gnome 44 backported keybind fixes broke Gnome 43 (and earlier) keybind clash detection #539
Merged
jtaala added a commit that referenced this issue May 30, 2023
@jtaala
REGRESSION FIX: Gnome 44 backported keybind fixes broke Gnome 43 (and…
e86f4d1 
… earlier) keybind clash detection (#539)

See #537 #538 PR's which reverts changes that were backported to Gnome
43/42. This PR is a replacement for these individual reverts PRs.

This PR implements a fix which first checks the number elements returned
from Gtk.accelerator_parse (whether 2 or 3) and assigns them correctly.
This is a much better/robust fix that means that this should now work
regardless of what gnome version is used.

Fixes #533, #536.

The issue was caused by Gtk.accelerator_parse result changing in Gnome
44. There is confusion about when this change occurred, e.g. [GJS
porting
guide](https://gjs.guide/extensions/upgrading/gnome-shell-40.html#gtk-accelerator-parse)
suggests this change occurred in Gnome 40, however actually testing in
Fedora 37 (and purportedly in other Gnome 43, 42) versions it's still
returning 2 elements instead of 3.

This PR addresses both cases.
@jtaala
Copy link
Collaborator

jtaala commented May 30, 2023

Hey @eliorc,

This should now be fixed in gnome-42 branch. Please do a:

git checkout gnome-42
git pull

and logout/login to get these fixes.

Thanks!

@jtaala jtaala closed this as completed May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Undesirable behavior
Projects
None yet
Milestone
No milestone
3 participants
@eliorc @jtaala @Lythenas