Gnome 42 support #418
Merged
Gnome 42 support #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class that ActionDispatcher is based on had some changes that needed to be brought over to this class. - Modal.pushModal() now returns a Clutter.Grab handle to allow easier checking of specific grab states - Clutter.Actor now does not emit key press events by default, this now requires a flag to be set Relevant changes: https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2045
We no longer need to do disable/enable cycles on screen locks: https://gjs.guide/extensions/upgrading/gnome-shell-42.html#metadata-json
These should ideally be generated using the gi-cli, as the packages are a bit out of date.
stage.grab(actor) now also grabs all pointer events, so it ended up blocking the DnD code. Motion events would also leak to the underlying MetaWindow when we released the native grab operation. A stage.grab also solves that since it grabs pointer events away from the MetaWindow.
From community PRs
This at least due to the preference window The new session-modes aren't supported by earlier versions either
|
Still relies on vertical-overview for gesture support, will probably fix that at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the buggy shadow when navigating workspaces by removing the offending box-shadow (probably due to changes in the upstream css engine). The border doesn't really stand out anymore if using the colored backgrounds.
Fixes DnD support. The
ActionDispatcheris now shared between the keyboard and DnD sincestage.grabnow grabs all pointer input too, ie. the DnD and the keybind dispatcher need to listen for events on the same actor.No longer does a disable/enable cycle on screen lock: https://gjs.guide/extensions/upgrading/gnome-shell-42.html#metadata-json
Also picked up the mentioned code from ccope#5 (couldn't test the touch support at the moment so left it off).
Only supports 42, so I created a gnome-40 branch, and will create a gnome-42 branch when this is merged.
closes #409, #417