Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GNOME 42 #409

Closed
smichel17 opened this issue Aug 15, 2022 · 7 comments · Fixed by #418
Closed

Support GNOME 42 #409

smichel17 opened this issue Aug 15, 2022 · 7 comments · Fixed by #418

Comments

@smichel17
Copy link
Collaborator

smichel17 commented Aug 15, 2022

Most of the code to do this already exists, but it is scattered around with a messy history and needs to be consolidated so it can be merged back here.

For now, if you are on GNOME 42 and you want to use a working PaperWM, use the gnome-42 branch of @ccope's fork: https://github.com/ccope/PaperWM/tree/gnome-42

edit: Also, you will almost certainly want to install the vertical overview extension alongside PaperWM.

@labuut
Copy link

labuut commented Sep 6, 2022

Hello! I've tried to use the gnome-42 branch of @ccope's fork and it works good, but I can't change keybindings. When I tried Paperwm with Gnome 3.38 it was a special window with keybindings which I could invoke on extension screen. But on Gnome 42 there isn't that button and I can't adjust hotkeys in default Keyboard-section in system settings. How can I change PaperWM's hotkeys?

@hedning
Copy link
Member

hedning commented Sep 7, 2022

This should work (assuming the path to the schemas directory is correct):

export GSETTINGS_SCHEMA_DIR=$HOME/.local/share/gnome-shell/extensions/paperwm@hedning:matrix.org/schemas 
dconf-editor /org/gnome/shell/extensions/paperwm/

@smichel17
Copy link
Collaborator Author

@hedning and @olejorgenb: While you're around, there's a bunch of old PRs, which I've marked as drafts: #188 #189 #191 #193 #194 #259

@ccope's gnome-42 branch also includes formatting the repo with prettier. Once it is merged, the old PRs will have a lot of merge conflicts. I can think of 3 options here:

  1. Try to merge as many of the old PRs as we can before merging the Prettier formatting.
  2. Merge the gnome-42 changes and worry about fixing merge conflicts in the PRs later.
  3. Drop the formatting with prettier, and fix up the gnome-42 changes so they will apply on top of the non-formatted repo.

I am inclined towards (1) for the smaller PRs and (2) for the larger PRs, which are likely to have merge conflicts in any case, but it's really a question of whether you are interested in putting any more effort into the PRs.

@hedning
Copy link
Member

hedning commented Sep 8, 2022

Hi, thanks for taking an active role :)

I took @ccope branch, removed the the prettier formatting and rebased it on develop here: https://github.com/hedning/PaperWM/tree/gnome-42

It looks up to date with the community edition to me, and works OK (the main annoyance is some weird fading when animating workspaces, haven't figured out where it comes from). If there's nothing missing I'll probably push it here (will probably stay on gnome 42 for a while now that I'm on the Ubuntu 22.04 LTS).

I'd also wait with prettier (especially the 4 -> 2 space thing, that will just cause trouble tbh). Would be nice to get #259 into gnome-42 it really improves the DnD experience, I'll probably take a crack at it fairly soon, as I'm already missing the functionality. (Never mind, looks like the code is develop, but we don't get any motion-events from the stage when navigation is activated).

@smichel17
Copy link
Collaborator Author

smichel17 commented Sep 8, 2022

There's also a few commits in ccope#5, which got lost on @ccope's gnome-42 branch somehow.

Besides that, I think everything from the fork has been merged back here (except these commits, and I am pretty sure they are included on the gnome-42 branch). So, I think I can go ahead and archive the community repo.

Hi, thanks for taking an active role :)

You're welcome :). I'm imagining my role as something like "steward of community contributions" — I'm up to help with issue tracking, deciding what to do with PRs, the parts of code review that don't require me to learn GJS (readability & logic bugs)… basically things that separate "I wrote this tool for my own use, do what you want with it" from a FLOSS project with a community.

I'd also wait with prettier

Sounds good

@indigoviolet
Copy link

indigoviolet commented Sep 8, 2022

There's also a few commits in ccope#5, which got lost on @ccope's gnome-42 branch somehow.

Just calling out that these fixes added back some Settings tabs (Keybindings, Backgrounds) that have gotten lost in hedning/PaperWM/tree/gnome-42.

@smichel17
Copy link
Collaborator Author

This is documented in the README now, so I'll un-pin

@smichel17 smichel17 unpinned this issue Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants